Convert framework-base and framework/* packages to modules#4105
Open
Convert framework-base and framework/* packages to modules#4105
Conversation
Saadnajmi
approved these changes
May 8, 2026
…tive into user/jasonvmo/esm-1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
This converts these to type="module" and stops the dual building. This will produce output in the /lib folder but no more /lib-commonjs. Metro can handle requiring these from CJS as can node 22+ and the tsconfig.json module settings make this transparent.
Running this through the pipelines now to ensure that our tests still pass.
Verification